[mono/monodevelop] [2 commits] 97bd04eb: Update GdbSession.cs

   Branch: refs/heads/master
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/ef394ec4ade8...b7002e4a46e4

   Commit: 97bd04ebc3060913d8ffb2d3bae104ee62bb09c8
   Author: Eko Wahyudin <[email protected]> (ekowahyudin)
     Date: 2013-11-14 04:41:06 GMT
      URL: https://github.com/mono/monodevelop/commit/97bd04ebc3060913d8ffb2d3bae104ee62bb09c8

Update GdbSession.cs

fix CheckBreakpoint function.
bp.TraceExpression sometime is empty or null, if that's happen, gdb will report an error System.InvalidOperationException: -data-evaluate-expression: Usage: -data-evaluate-expression expression.

Changed paths:
  M extras/MonoDevelop.Debugger.Gdb/GdbSession.cs

Modified: extras/MonoDevelop.Debugger.Gdb/GdbSession.cs
===================================================================
@@ -345,7 +345,7 @@ bool CheckBreakpoint (int handle)
 				RunCommand ("-break-condition", handle.ToString (), "(" + bp.ConditionExpression + ") != " + val);
 			}
 			
-			if (bp.HitAction == HitAction.PrintExpression) {
+			if (!string.IsNullOrEmpty (bp.TraceExpression) && bp.HitAction == HitAction.PrintExpression) {
 				GdbCommandResult res = RunCommand ("-data-evaluate-expression", Escape (bp.TraceExpression));
 				string val = res.GetValue ("value");
 				NotifyBreakEventUpdate (binfo, 0, val);

   Commit: b7002e4a46e42cb33912fb97ce5816ad65504350
   Author: Jeffrey Stedfast <[email protected]> (jstedfast)
     Date: 2013-11-14 11:50:51 GMT
      URL: https://github.com/mono/monodevelop/commit/b7002e4a46e42cb33912fb97ce5816ad65504350

Merge pull request #432 from ekowahyudin/patch-1

Update GdbSession.cs

Changed paths:
  M extras/MonoDevelop.Debugger.Gdb/GdbSession.cs

Modified: extras/MonoDevelop.Debugger.Gdb/GdbSession.cs
===================================================================
@@ -345,7 +345,7 @@ bool CheckBreakpoint (int handle)
 				RunCommand ("-break-condition", handle.ToString (), "(" + bp.ConditionExpression + ") != " + val);
 			}
 			
-			if (bp.HitAction == HitAction.PrintExpression) {
+			if (!string.IsNullOrEmpty (bp.TraceExpression) && bp.HitAction == HitAction.PrintExpression) {
 				GdbCommandResult res = RunCommand ("-data-evaluate-expression", Escape (bp.TraceExpression));
 				string val = res.GetValue ("value");
 				NotifyBreakEventUpdate (binfo, 0, val);


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches