[mono/monodevelop] 9fc3b580: [Ide] readonlyification

   Branch: refs/heads/master
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/2280ebbd03e6...9fc3b5805ece

   Commit: 9fc3b5805ecea408142f85b5e220bd986fe51544
   Author: Jeffrey Stedfast <[email protected]> (jstedfast)
     Date: 2013-11-14 17:47:38 GMT
      URL: https://github.com/mono/monodevelop/commit/9fc3b5805ecea408142f85b5e220bd986fe51544

[Ide] readonlyification

Changed paths:
  M main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.OptionPanels/MonoRuntimePanel.cs
  M main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Projects.OptionPanels/CombineBuildOptions.cs
  M main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Projects.OptionPanels/RuntimeOptionsPanel.cs

Modified: main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.OptionPanels/MonoRuntimePanel.cs
===================================================================
@@ -25,12 +25,15 @@
 // THE SOFTWARE.
 
 using System;
+using System.Linq;
 using System.Collections.Generic;
+
+using Gtk;
+
 using MonoDevelop.Core;
 using MonoDevelop.Ide.Gui.Dialogs;
 using MonoDevelop.Core.Assemblies;
 using MonoDevelop.Components;
-using Gtk;
 
 namespace MonoDevelop.Ide.Gui.OptionPanels
 {
@@ -52,9 +55,9 @@ public override void ApplyChanges ()
 	[System.ComponentModel.ToolboxItem(true)]
 	internal partial class MonoRuntimePanelWidget : Gtk.Bin
 	{
-		ListStore store;
-		List<MonoRuntimeInfo> newInfos = new List<MonoRuntimeInfo> ();
-		List<TargetRuntime> removedRuntimes = new List<TargetRuntime> ();
+		readonly List<TargetRuntime> removedRuntimes = new List<TargetRuntime> ();
+		readonly List<MonoRuntimeInfo> newInfos = new List<MonoRuntimeInfo> ();
+		readonly ListStore store;
 		TreeIter defaultIter;
 		TreeIter runningIter;
 		
@@ -101,13 +104,14 @@ public void Store ()
 			MonoRuntimeInfo newDefaultInfo = ob as MonoRuntimeInfo;
 			if (ob is TargetRuntime)
 				IdeApp.Preferences.DefaultTargetRuntime = (TargetRuntime)ob;
-			
-			foreach (MonoRuntimeInfo rinfo in newInfos) {
+
+			foreach (var rinfo in newInfos) {
 				TargetRuntime tr = MonoTargetRuntime.RegisterRuntime (rinfo);
 				if (rinfo == newDefaultInfo)
 					IdeApp.Preferences.DefaultTargetRuntime = tr;
 			}
-			foreach (MonoTargetRuntime tr in removedRuntimes)
+
+			foreach (var tr in removedRuntimes.OfType<MonoTargetRuntime> ())
 				MonoTargetRuntime.UnregisterRuntime (tr);
 			
 		}

Modified: main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Projects.OptionPanels/CombineBuildOptions.cs
===================================================================
@@ -46,7 +46,7 @@ public override void ApplyChanges ()
 
 	partial class CombineBuildOptionsWidget : Gtk.Bin 
 	{
-		Solution solution;
+		readonly Solution solution;
 		
 		public CombineBuildOptionsWidget (Solution solution)
 		{

Modified: main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Projects.OptionPanels/RuntimeOptionsPanel.cs
===================================================================
@@ -60,8 +60,8 @@ public override void ApplyChanges()
 
 	partial class RuntimeOptionsPanelWidget : Gtk.Bin 
 	{
-		DotNetProject project;
-		List<TargetFramework> frameworks;
+		readonly List<TargetFramework> frameworks;
+		readonly DotNetProject project;
 
 		public RuntimeOptionsPanelWidget (DotNetProject project, IEnumerable<ItemConfiguration> configurations)
 		{
@@ -83,7 +83,7 @@ public RuntimeOptionsPanelWidget (DotNetProject project, IEnumerable<ItemConfigu
 				notInstalled = true;
 				frameworks.Add (project.TargetFramework);
 			}
-				
+
 			//sort by id ascending, version descending, profile ascending
 			frameworks.Sort ((x, y) => {
 				var cmp = string.CompareOrdinal (x.Id.Identifier, y.Id.Identifier);


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches