[mono/monodevelop] 627293a7: [Subversion] Added URL validation tests.

   Branch: refs/heads/master
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/b03633c39157...627293a7e64b

   Commit: 627293a7e64b228277fc46d8a24021d15bb20f2a
   Author: Therzok <[email protected]> (Therzok)
     Date: 2013-11-18 17:40:24 GMT
      URL: https://github.com/mono/monodevelop/commit/627293a7e64b228277fc46d8a24021d15bb20f2a

[Subversion] Added URL validation tests.

Changed paths:
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Git.Tests/BaseGitRepositoryTests.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Git.Tests/BaseRepositoryTests.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Tests/BaseSvnRepositoryTests.cs
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Tests/RepositoryTests.cs
  M main/src/addins/VersionControl/Subversion.Win32.Tests/RepositoryTests.cs

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Git.Tests/BaseGitRepositoryTests.cs
===================================================================
@@ -269,8 +269,7 @@ public void TestPushDiff ()
 			//Assert.AreEqual ("text2", item.Content);
 		}
 
-		[Test]
-		public void TestGitUrl ()
+		protected override void TestValidUrl ()
 		{
 			var repo2 = (GitRepository)Repo;
 			Assert.IsTrue (repo2.IsUrlValid ("[email protected]:mono/monodevelop"));


Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Git.Tests/BaseRepositoryTests.cs
===================================================================
@@ -125,6 +125,14 @@ public void RightRepositoryDetection ()
 		protected abstract NUnit.Framework.Constraints.IResolveConstraint IsCorrectType ();
 
 		[Test]
+		public void UrlIsValid ()
+		{
+			TestValidUrl ();
+		}
+
+		protected abstract void TestValidUrl ();
+
+		[Test]
 		// Tests Repository.Checkout.
 		public void CheckoutExists ()
 		{

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Tests/BaseSvnRepositoryTests.cs
===================================================================
@@ -93,6 +93,15 @@ protected override NUnit.Framework.Constraints.IResolveConstraint IsCorrectType
 			return Is.InstanceOf<SubversionRepository> ();
 		}
 
+		protected override void TestValidUrl ()
+		{
+			var repo2 = (SubversionRepository)Repo;
+			Assert.IsTrue (repo2.IsUrlValid ("svn://svnrepo.com:80/repo"));
+			Assert.IsTrue (repo2.IsUrlValid ("svn+ssh://[email protected]:80/repo"));
+			Assert.IsTrue (repo2.IsUrlValid ("http://svnrepo.com:80/repo"));
+			Assert.IsTrue (repo2.IsUrlValid ("https://svnrepo.com:80/repo"));
+		}
+
 		protected override Revision GetHeadRevision ()
 		{
 			return SvnRevision.Head;


Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion.Tests/RepositoryTests.cs
===================================================================
@@ -127,6 +127,12 @@ protected override void PostUnlock ()
 			});
 		}
 
+		public override void TestValidUrl ()
+		{
+			base.TestValidUrl ();
+			Assert.IsTrue (Repo.IsUrlValid ("file:///dir/repo"));
+		}
+
 		protected override Repository GetRepo (string path, string url)
 		{
 			return new SubversionRepository (new SvnClient (), url, path);

Modified: main/src/addins/VersionControl/Subversion.Win32.Tests/RepositoryTests.cs
===================================================================
@@ -117,6 +117,16 @@ protected override void PostUnlock ()
 			});
 		}
 
+		[Test]
+		protected override void TestValidUrl ()
+		{
+			base.TestValidUrl ();
+
+			Assert.Ignore ("File scheme is broken on Windows");
+			var repo2 = (SubversionRepository)Repo;
+			Assert.IsTrue (repo2.IsUrlValid ("file:///c:/dir/repo"));
+		}
+
 		protected override Repository GetRepo (string path, string url)
 		{
 			return new SubversionRepository (new SvnSharpClient (), url, path);



_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches