[mono/monodevelop] dae3c0cb: [Git] Remove keychain storage for git passwords

   Branch: refs/heads/master
     Home: https://github.com/mono/monodevelop
  Compare: https://github.com/mono/monodevelop/compare/522f7954e148...dae3c0cb7d36

   Commit: dae3c0cb7d360014dcac2ed80de4c7f220b7c275
   Author: Ungureanu Marius <[email protected]> (Therzok)
     Date: 2013-11-20 23:04:35 GMT
      URL: https://github.com/mono/monodevelop/commit/dae3c0cb7d360014dcac2ed80de4c7f220b7c275

[Git] Remove keychain storage for git passwords

Until we find a better way to store them and not be corrupted.

Downside: It requires pass input on every push.

Changed paths:
  M main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git/GitCredentials.cs

Modified: main/src/addins/VersionControl/MonoDevelop.VersionControl.Git/MonoDevelop.VersionControl.Git/GitCredentials.cs
===================================================================
@@ -56,7 +56,7 @@ public override bool Get (URIish uri, params CredentialItem[] items)
 			
 			// We always need to run the TryGet* methods as we need the passphraseItem/passwordItem populated even
 			// if the password store contains an invalid password/no password
-			if (TryGetUsernamePassword (uri, items, out passwordItem) || TryGetPassphrase (uri, items, out passphraseItem)) {
+			if (/*TryGetUsernamePassword (uri, items, out passwordItem) || */TryGetPassphrase (uri, items, out passphraseItem)) {
 				// If the password store has a password and we already tried using it, it could be incorrect.
 				// If this happens, do not return true and ask the user for a new password.
 				if (!HasReset) {
@@ -75,9 +75,9 @@ public override bool Get (URIish uri, params CredentialItem[] items)
 				
 			HasReset = false;
 			if (result) {
-				if (passwordItem != null) {
+				/*if (passwordItem != null) {
 					PasswordService.AddWebPassword (new Uri (uri.ToString ()), new string (passwordItem.GetValue ()));
-				} else if (passphraseItem != null) {
+				} else*/ if (passphraseItem != null) {
 					PasswordService.AddWebPassword (new Uri (uri.ToString ()), passphraseItem.GetValue ());
 				}
 			}


_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches