Re: New GIOP timeout patch - please review

Michael Meeks <[email protected]> Thu, 21 Jun 2007 12:46:23 +0100
Newsgroups gmane.comp.gnome.orbit.general
Organization Novell, Inc.
Message-ID <1182426383.3917.96.camel@localhost>
Hi Jules,

On Thu, 2007-06-21 at 14:49 +0200, Jules Colding wrote:
> As always... Just noticed two small and stupid bugs. Corrected patch
> below.

	Sigh - so 1 new thread per IPv4 connection ? that will cripple Sun who
use IPv4/CORBA to do their Java a11y bridging stuff. We should only do
that as a stop-gap, and only if it's turned off by default for IPv4
users I think [ is that so ? ].

	-really- it would be way better to instrument your glib and find out
why the timeout thing is not getting called. -One- possibility may be
that you're not setting it to be a 'recursive' source (although perhaps
unlikely given the lack of re-enterancy there).

	HTH,

		Michael.

-- 
 [email protected]  <><, Pseudo Engineer, itinerant idiot