Re: PATCH: Fix and simplify get_netid()
Jules Colding <[email protected]> Mon, 23 Jun 2008 10:41:08 +0200
| Newsgroups | gmane.comp.gnome.orbit.general |
|---|---|
| Message-ID | <[email protected]> |
On 21/06/2008, at 21.29, Jules Colding wrote: > Hi, > > The linc2/src/linc-protocols.c:get_netid() function produced > nonsense values for ORBNetID="ipaddr" on Mac OS X Leopard. Please see: > > http://bugzilla.gnome.org/show_bug.cgi?id=539510 > > > The patch below fixes this and makes for a simpler get_netid() bu > introducing a new helper function. The patch has been tested on > Leopard and Ubuntu Gutsy. "make check" is also happy on both > platforms. Please forgive me if the patch below is whitespace-messed- > up. My current mailer isn't too happy about inserted text... > > May I commit? Comments? Committed. Hopefully people will yell at me if something breaks... -- jules