Re: Memory leak with inout parameters

Alex Hornby <[email protected]> 26 Nov 2002 09:18:55 +0000
Newsgroups gmane.comp.gnome.orbit.perl
Message-ID <[email protected]>
On Tue, 2002-11-26 at 04:21, [email protected] wrote:
> This patch fixes the leak. I'll make a new release shortly. Sorry for the
> lack of communication recently, I relocated to New York from Tokyo and
> have been busy. Here's the patch. -Huw
> 
> Index: server.c
> ===================================================================
> RCS file: /cvs/gnome/orbit-perl/server.c,v
> retrieving revision 1.8
> diff -c -r1.8 server.c
> *** server.c    7 Jul 2002 12:18:45 -0000       1.8
> --- server.c    26 Nov 2002 03:29:31 -0000
> ***************
> *** 445,450 ****
> --- 445,451 ----
>    clean2:
>       if (inout_args) {
>         av_undef (inout_args);
> +       SvREFCNT_dec (inout_args);
>         inout_args = NULL;
>       }
> 

Thanks Huw.

BTW have you spent any more time on the ORBit2 bindings? The python
bindings seem to be coming along, so hopefully all the necessary hooks
are in place in the C libs.

Cheers,
Alex.