Re: [patch] Rework of Pango integration

On Wed, 2004-06-09 at 10:02, Jody Goldberg wrote:
> On Thu, Jun 03, 2004 at 08:54:58PM -0400, Owen Taylor wrote:
> > I've been working recently on redoing the Pango support in gnome-print;
> > here's a first pass at a patch.
> > 
> > It's actually not that conceptually different from what Jean did
> > with gnome_print_pango_layout_print() ... it doesn't create a new
> > Pango backend, but simply uses the FT2 backend and converts
> > PangoFont to GnomeFont when creating the GnomeGlyphList structures.
> 
> Actually one other consideration.
>     http://bugzilla.gnome.org/show_bug.cgi?id=143542
> This leak seems to be at the pango level.  It looks likely that the
> patch would trigger the problem.

Well, my guess is that virtually all people using this stuff will
be using the global-singleton, which there isn't even a way to free,
so it's not especially relevant.

I don't think fixing 143542 is that hard; you'd need to make 
fcfont->fontmap a weak reference and then make the font do some
harmless fallback if it is NULL. (Or just make accessing a font
after the fontmap has been freed illegal.)

Regards,
						Owen

_______________________________________________
gnome-print-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/gnome-print-list

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQBAxyUNS+2LB0B90LERAoEcAJsEZIFThDYXdgziNKMj29ToCCemLwCfV1IN
XnymgqY0zFVUl/AZzYiPM8I=
=oO6i
-----END PGP SIGNATURE-----