Re: guchar -> gchar?

--===============1382456728==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-R1qrMRTpsziO7yXjGArC"


--=-R1qrMRTpsziO7yXjGArC
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, 2005-03-08 at 08:02 +0200, Lutz M=FCller wrote:
> On Tue, 2005-08-02 at 18:04 -0600, Andreas J. Guelzow wrote:
> > It will likely cause lots of warning messages in existing code using
> > guchar* to call those functions! Note that the real cause of the
> > warnings that you see is _not_ that those functions expect guchar* but
> > that you (or whoever wrote the code) is passing to them gchar*.
>=20
> strlen, strdup, strcpy all use char. The convention seems to use char
> for all (user readable) strings. I don't see added value for=20
> - casting strings to unsigned char when passing them to libgnomeprint
> - casting them to char within libgnomeprint
> - casting them to unsigned char when returning them
> - casting them to char for further use in the calling function.

This may have been an argument to use gchar* when gnomeprint was first
written, but you are arguing to _changge_ the types and to create
warnings for a large body of code that so far has coretly used that API.

I do not think that this is sufficient reason to break the API.

Andreas

--=20
Andreas J. Guelzow
Taliesin Software, Shelties, Pyr Sheps
and Shetland Sheep

--=-R1qrMRTpsziO7yXjGArC
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBC8GDEJ1WZh1HYgPsRArf8AKC7/R7j/dyC3DU/b8MySP7N2z3S6ACgnri9
16B2SozhX0MDmE+OPVtKRts=
=1k+P
-----END PGP SIGNATURE-----

--=-R1qrMRTpsziO7yXjGArC--


--===============1382456728==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
gnome-print-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/gnome-print-list

--===============1382456728==--