Re: Patch in trunk r19886 might influence engines

On Sun, 2008-03-16 at 03:16 +0100, Alberto Ruiz wrote:
> Engine developers should take a look at it, this patch corrects the
> combobox size allocation which was overriding the border-width of the
> combobox and the thickness of the frame. The only engine which exposed
> the problem so far has been the ms-windows one (wimp).

I don't know of any other theme that sets the GtkComboBox::shadow-type
style property. The patch will only have an effect on engines using it,
and it fixes the bug that the containers border was ignored.

> I have tested with some engines already, but please, check your
> engines with different thickness and border values for the ComboBox in
> all its possible variants, and the frame inside and see if it behaves
> correctly and there's no deprecated workaraounds in place.

Just tested with a couple of themes and it works fine.

> If none raises comments my plan is to backport the bug to 2.12

Current 2.12 seems to contain a bug. At least the debian package that I
have (2.12.9-2) has some broken implementation, while trunk with your
patch is working fine.

Benjamin

_______________________________________________
gnome-themes-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/gnome-themes-list

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBH4CktJddvdAxOva4RAvphAJ43EveoKTnzVU7q5H2NJXKJa4Ff8gCeLRpO
tlQnxgg4Lr6MW4bPwbDt7To=
=qQNS
-----END PGP SIGNATURE-----