Re: Code freeze break request

--===============1767818885==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-lNjYFbIaNy26xcJcfOZG"


--=-lNjYFbIaNy26xcJcfOZG
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am Freitag, den 07.03.2008, 13:49 +0100 schrieb Alexander Larsson:
> On Fri, 2008-03-07 at 13:02 +0100, Kjartan Maraas wrote:
> > fr., 07.03.2008 kl. 12.51 +0100, skrev Alexander Larsson:
> > > On Fri, 2008-03-07 at 12:43 +0100, Kjartan Maraas wrote:
> > > > fr., 07.03.2008 kl. 12.40 +0100, skrev Vincent Untz:
> > > > > Le vendredi 07 mars 2008, =C3=A0 12:38 +0100, Alexander Larsson a=
 =C3=A9crit :
> > > > > >=20
> > > > > > On Fri, 2008-03-07 at 12:36 +0100, Vincent Untz wrote:
> > > > > >=20
> > > > > > > > --- hal/ghalmount.c	(revision 1602)
> > > > > > > > +++ hal/ghalmount.c	(working copy)
> > > > > > > > @@ -209,9 +209,9 @@
> > > > > > > >      }
> > > > > > > >   =20
> > > > > > > >    if (is_blank)
> > > > > > > > -    return disc_data[n].ui_name_blank;
> > > > > > > > +    return gettext(disc_data[n].ui_name_blank);
> > > > > > > >    else
> > > > > > > > -    return disc_data[n].ui_name;
> > > > > > > > +    return gettext(disc_data[n].ui_name);
> > > > > > > >  }
> > > > > > >=20
> > > > > > > Why aren't you using _()? Else, approval 1 of 2.
> > > > > >=20
> > > > > > Wouldn't that mark it for translation?
> > > > >=20
> > > > > I think not. It only mark things for translation when they are co=
nstant
> > > > > strings (as in "something") and not when they are variables. At l=
east, I
> > > > > seriously hope it does this :-)
> > > > >=20
> > > > >From gi18n.h:
> > > > #define  _(String) gettext (String)
> > >=20
> > > Sure, the question is not what the code does, but how the gettext/pof=
ile
> > > machinery handles it.
> > >=20
> > It handles it with _() as well IIRC. I've seen that used in many places
> > and never found such things in the po-files.
>=20
> Other places in nautilus use gettext() for this case. I doubt it matters
> either way. Anyway, can i get a 2nd ack?

approval 2 of 2.

andre
--=20
 mailto:[email protected] | failed
 http://www.iomc.de/  | http://blogs.gnome.org/aklapper

--=-lNjYFbIaNy26xcJcfOZG
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Dies ist ein digital signierter Nachrichtenteil

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBH0TsqUZw3dUr5LoARAun+AKDnNR56Ffoz8BqxTMvC04hPrrgVQQCeL2t/
NNC/VEBQA7HUy/VWZ6ecWR8=
=LeRe
-----END PGP SIGNATURE-----

--=-lNjYFbIaNy26xcJcfOZG--


--===============1767818885==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
gnome-vfs-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/gnome-vfs-list

--===============1767818885==--