Re: [GNOME VFS] file module bugs

Alex,

If you'd be willing to commit this to both HEAD and gnome-2-0 that'd be
great, otherwise tell me which one you committed it to and I'll do the
other.

-Seth

On Thu, 2002-07-11 at 05:55, Alexander Larsson wrote:
> I found two bugs in the file module, one is the infamouse nautilus Trash 
> file trasher. I'm gonna check these in soon, unless someone stops me:
> 
> Index: modules/file-method.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/modules/file-method.c,v
> retrieving revision 1.105.2.1
> diff -u -p -r1.105.2.1 file-method.c
> --- modules/file-method.c	13 Jun 2002 19:24:04 -0000	1.105.2.1
> +++ modules/file-method.c	11 Jul 2002 10:39:59 -0000
> @@ -190,8 +190,8 @@ do_open (GnomeVFSMethod *method,
>  	}
>  
>  	if (! (mode & GNOME_VFS_OPEN_RANDOM) && (mode & GNOME_VFS_OPEN_WRITE))
> -		mode |= O_TRUNC;
> -
> +		unix_mode |= O_TRUNC;
> +	
>  	file_name = get_path_from_uri (uri);
>  	if (file_name == NULL)
>  		return GNOME_VFS_ERROR_INVALID_URI;
> @@ -667,7 +667,7 @@ get_stat_info (GnomeVFSFileInfo *file_in
>  			                /* if we had an earlier ELOOP, don't get in an infinite loop here */
>  			        || recursive
>  					/* we don't care to follow links */
> -				|| lstat (file_info->symlink_name, statptr) != 0
> +				|| lstat (symlink_name, statptr) != 0
>  					/* we can't make out where this points to */
>  				|| !S_ISLNK (statptr->st_mode)) {
>  					/* the next level is not a link */
> 
> -- 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    [email protected]    [email protected] 
> He's a short-sighted voodoo cowboy for the 21st century. She's a 
> transdimensional hip-hop snake charmer prone to fits of savage, blood-crazed 
> rage. They fight crime! 
> 
> 
> _______________________________________________
> gnome-vfs maillist  -  [email protected]
> http://lists.ximian.com/mailman/listinfo/gnome-vfs



_______________________________________________
gnome-vfs maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/gnome-vfs