Re: Patch for Clang

Thank you for the patch.

I noticed you are using Aspell 0.61 which is now the "devel" branch in CVS.  I 
have not done any work on this branch yet, but when I do I will make sure it 
compiles with Clang and take your patch into account.

Note: I fixed the "master" branch for Aspell 0.60 so that it can compile for 
Clang.

Thanks,
Kevin


On Mon, 12 Dec 2016, Hypo Stases wrote:

> Dear Kevin,
> Here's the patch essential for being able to compile Aspell
> by clang.
>
> Compilation by clang++ on Mac (Apple LLVM version 7.0.2 (clang-700.1.81))
> is broken.
>
> It complains about 3 issues with templates like failing to void-reference
> instantiation, and 2 issues in in visibility of resolving.
>
> There's one more issue at the linking step.
>
> The patch is attached as well as inlined.
>
> Thank you for the great Aspell!
>
> Kind regards,
> Hypo
>
>
> diff -Naru aspell-0.61/common/hash.hpp aspell-0.61-mac-patched/common
> /hash.hpp
> --- aspell-0.61/common/hash.hpp    2016-02-22 14:58:15.000000000 +0200
> +++ aspell-0.61-mac-patched/common/hash.hpp    2016-02-22
> 17:02:55.000000000 +0200
> @@ -324,7 +324,7 @@
>       : Base(s, Parms(h,e)) {}
>     data_type & operator[](const key_type & k)
>     {
> -      return (*((insert(value_type(k, data_type()))).first)).second;
> +      return (*((this->insert(value_type(k, data_type()))).first)).second;
>     }
>   };