Re: ASPELL aspell-0.60.8.1 compilation failure on MSYS2 + MINGW64

--8323329-1665055590-1746762693=:27400
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 8BIT

On Tue, 6 May 2025, Vincent Belaïche wrote:

> Hello,
> Here is what I get when compiling from sources on MINGW64 (attached config.log and compilation log) :
>
> ==========================================================
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./gen -I./gen -I./common -I./interfaces/cc/ -I./modules/speller/default/ -DLOCALEDIR=/mingw64/share/locale -I/mingw64/include -g -O2 -fno-exceptions -MT common/file_util.lo -MD -MP -MF common/.deps/file_util.Tpo -c common/file_util.cpp  -DDLL_EXPORT -DPIC -o common/.libs/file_util.o
> common/file_util.cpp: In function 'bool acommon::need_dir(ParmString)':
> common/file_util.cpp:49:13: error: 'asc_isalpha' was not declared in this scope; did you mean 'isalpha'?
>   49 |         || (asc_isalpha(file[0]) && file[1] == ':')
>      |             ^~~~~~~~~~~
>      |             isalpha
> common/file_util.cpp:56:3: warning: control reaches end of non-void function [-Wreturn-type]
>   56 |   }
>      |   ^
> make[1]: *** [Makefile:1524: common/file_util.lo] Error 1
> make[1]: Leaving directory '/c/Users/vincentbelaiche/Downloads/aspell-0.60.8.1'
> make: *** [Makefile:1657: all-recursive] Error 1
> ==========================================================

asc_isalpha is defined in "asc_ctype.hpp" but it is only used if WIN32 is 
defined so it's not normally included.  I don't have easy access to a Windows 
machine right now but the attached patch should fix your complication problem.

Kevin


--8323329-1665055590-1746762693=:27400
Content-Type: text/x-diff; name=win32-compile-fix.diff
Content-Transfer-Encoding: BASE64
Content-ID: <[email protected]>
Content-Description: 
Content-Disposition: attachment; filename=win32-compile-fix.diff

LS0tIGNvbW1vbi9maWxlX3V0aWwuY3BwfgkyMDIzLTEyLTAzIDAwOjA5OjUy
LjAwMDAwMDAwMCAtMDUwMA0KKysrIGNvbW1vbi9maWxlX3V0aWwuY3BwCTIw
MjUtMDUtMDggMjM6MzE6MTQuMTE2MDYwMjUyIC0wNDAwDQpAQCAtMzAsNiAr
MzAsNyBAQA0KICMgIGRlZmluZSBBQ0NFU1MgX2FjY2Vzcw0KICMgIGluY2x1
ZGUgPHdpbmRvd3MuaD4NCiAjICBpbmNsdWRlIDx3aW5iYXNlLmg+DQorIyAg
aW5jbHVkZSAiYXNjX2N0eXBlLmhwcCINCiANCiAjZWxzZQ0KIA0K

--8323329-1665055590-1746762693=:27400--