Re: need your review: code change for porting to Solaris+forte

On 17/08/04, 18:37:17, Calvin Liu <[email protected]> wrote regarding
[aspell-devel] need your review: code change for porting to 
Solaris+forte:

> == begin quote ==
> line 636:          dup_pair = duplicates_check.insert(fix_case(word));
>          if (dup_pair.second &&
>              ((pos = dup_pair.first->find(' '), pos == String::npos)
>               ? (bool)speller->check(*dup_pair.first)
>               : (speller->check((String)dup_pair.first->substr(0,pos))
>                  &&
> speller->check((String)dup_pair.first->substr(pos+1))) ))
>            near_misses_final->push_back(*dup_pair.first);
>        }
>      } else {
> == end quote ==

> I changed it into:
> == begin quote ==
> line 636:          dup_pair = duplicates_check.insert(fix_case(word));
>          if (dup_pair.second) {
>                pos = dup_pair.first->find(' ');
>                if (pos == String::npos){
>                        speller->check(*dup_pair.first);

No, this value is "returned" by the ternary op and here it's ignored.


>                        near_misses_final->push_back(*dup_pair.first);
>                }
>                else {

> speller->check((String)dup_pair.first->substr(0,pos));

> speller->check((String)dup_pair.first->substr(pos+1));
>                }
>          } //if
>        } //while
>      } else {
> == end quote ==