need your review: code change for porting to Solaris+forte

Calvin Liu <[email protected]>
Newsgroups gmane.comp.gnu.aspell.devel
Message-ID <[email protected]>
Hi, there,

Please reply to me directly because I haven't subscribe to this mail 
alias. Thanks in advance!

I need to build aspell-0.50.3 on Solaris with forte compiler. Here's a 
piece of code that I made some change. It passed the compiler but I'm 
not sure that's what the origional code want to do.

Please reply to me directly because I haven't subscribe to this mail 
alias. Thanks in advance!

For file aspell-0.50.3/moduels/spell/default/suggest.cpp, there's a 
piece of code that cause compiler error:
== begin quote ==
line 636:          dup_pair = duplicates_check.insert(fix_case(word));
          if (dup_pair.second &&
              ((pos = dup_pair.first->find(' '), pos == String::npos)
               ? (bool)speller->check(*dup_pair.first)
               : (speller->check((String)dup_pair.first->substr(0,pos))
                  && 
speller->check((String)dup_pair.first->substr(pos+1))) ))
            near_misses_final->push_back(*dup_pair.first);
        }
      } else {
== end quote ==

So I changed it into:
== begin quote ==
line 636:          dup_pair = duplicates_check.insert(fix_case(word));
          if (dup_pair.second) {
                pos = dup_pair.first->find(' ');
                if (pos == String::npos){
                        speller->check(*dup_pair.first);
                        near_misses_final->push_back(*dup_pair.first);
                }
                else {
                        
speller->check((String)dup_pair.first->substr(0,pos));
                        
speller->check((String)dup_pair.first->substr(pos+1));
                }
          } //if
        } //while
      } else {
== end quote ==

Is it correct to do this? I really need someone to review it.

Thanks.
Calvin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.