Re: Port to Win32

On Tue, 21 Sep 2004, Gary Setter wrote:

> <snip>
> > > I only have VC6.0 and Borlands BCB5.5. So that is what I'm
> > > porting to.
> >
> > CygWin and MinGW use Gcc and available for free.  Do a Google
> search.
> I didn't say I could not have them, I said that I did not have
> them. What I have suits me fine.

With a little effort Aspell should compile just fine under CygWin and 
MinGW.  These binaries can be used by other applications since I use a C 
interface.  There for I find this the best solution.

> > > I've tried to express why I believe the ported code is better
> > > code. Why do you believe that it is not?
> >
> > Because the changes to get Aspell to compile with VC are
> generally ugly.
> 
> Sometimes, sometimes not.
> Take this line from convert.hpp
>   class Convert {
>   private:
>     static const size_t memory_size = 96;
> };
> I believe it is none standard to initialize member data in a
> class definition.

You are wrong.  It is allowed if it is an int type.

> The alternative is using an enum. Not ugly at all.
> 
>   enum {memory_size = 96};

In my view yes.

By ugly I main VC++ specific hacks like the one above.

> What is the alternative? What is happening now is the same things
> have to be changed to port the code with each release. That seems
> kind of ugly to me.

You are welcome to submit patches.  I may even approve them into the main 
source if they are not too ugly.

I personally do not think it is worth the effort.

-- 
http://kevin.atkinson.dhs.org