Re: Patch to 1.2.14pl2

Anthony DeRobertis <[email protected]> Tue, 16 May 2006 09:36:29 -0400
Newsgroups gmane.comp.gnu.bayonne.devel
Message-ID <[email protected]>
Anthony DeRobertis wrote:
> One of the buffers used to execute TGIs is too small leading to a a 
> buffer overflow on the stack (and, of course, a crash). This patch 
> fixes it. 

Ugh, mailing list software seems to have stripped it....

diff -rdbU3 bayonne-1.2.14pl2/server/dso.cpp bayonne-1.2.14pl2.new/server/dso.cpp
--- bayonne-1.2.14pl2/server/dso.cpp	2003-02-27 11:33:17.000000000 -0500
+++ bayonne-1.2.14pl2.new/server/dso.cpp	2006-05-10 16:01:58.000000000 -0400
@@ -701,7 +701,7 @@
 {
 	TGI *tgi = TGI::first;
 	char *ext;
-	char buffer[512];
+	char buffer[TGI_BUF];
 	strcpy(buffer, cmd);
 	cmd = strtok_r(buffer, " \t\n", &ext);
 	ext = strrchr(cmd, '.');


Hopefully, it still applies after being copy & pasted into the body of 
an email.