[binutils-gdb] PR 34275 double free in ctf_link_deduplicating_per_cu

Alan Modra via Binutils-cvs <[email protected]> Fri, 3 Jul 2026 23:53:27 +0000 (GMT)
Newsgroups gmane.comp.gnu.binutils.cvs
Message-ID <[email protected]>
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b2ba16132fe4ecdb1ae112e017266b045de9dd80

commit b2ba16132fe4ecdb1ae112e017266b045de9dd80
Author: xuqing yang <[email protected]>
Date:   Wed Jun 10 14:12:05 2026 +0000

    PR 34275 double free in ctf_link_deduplicating_per_cu
    
            * ctf-link.c (ctf_link_deduplicating_per_cu): Don't call
            ctf_next_destroy twice on error path.

Diff:
---
 libctf/ctf-link.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/libctf/ctf-link.c b/libctf/ctf-link.c
index 9fdd39fdb95..c6d0a86f4b7 100644
--- a/libctf/ctf-link.c
+++ b/libctf/ctf-link.c
@@ -1187,10 +1187,7 @@ ctf_link_deduplicating_per_cu (ctf_dict_t *fp)
 
       if ((inputs = ctf_link_deduplicating_open_inputs (fp, in, ninputs,
 							&parents)) == NULL)
-	{
-	  ctf_next_destroy (i);
-	  goto err_open_inputs;
-	}
+	goto err_open_inputs;
 
       if ((out = ctf_create (&err)) == NULL)
 	{