Re: [PATCH] PE/COFF: auto-promote to bigobj target when section count overflows

On 22.06.2026 21:26, Oleg Tolmatcev wrote:
> Am Mo., 22. Juni 2026 um 09:46 Uhr schrieb Jan Beulich <[email protected]>:
>>> --- a/gas/testsuite/gas/pe/pe.exp
>>> +++ b/gas/testsuite/gas/pe/pe.exp
>>> @@ -70,4 +70,5 @@ if {[istarget "aarch64-*-pe*"] || [istarget "aarch64-*-mingw*"]} {
>>>
>>>  if ([istarget "*-*-mingw*"]) then {
>>>       run_dump_test "big-obj"
>>> +     run_dump_test "big-obj-auto"
>>>  }
>>
>> Why would the test want limiting to MinGW?
> 
> I don't know because I didn't write that code.

You didn't write the original code, but it was you who decided to insert the
new test's running inside the conditional, rather than outside (or in a new,
less restrictive one). Especially since the new "default to big-obj if needed"
isn't (directly) target dependent, the new test also should cover all targets
which are affected by the change.

Of course there's the orthogonal issue of the pre-existing conditional wanting
relaxing. That's not something I'm demanding you to do at the same time (yet
of course I wouldn't mind if you did). The three bfd/pe-*.c which #define
COFF_WITH_PE_BIGOBJ do so entirely unconditionally, afaics. Hence that's the
pattern we want to also use for engaging the pre-existing and the new test.

Jan