Re: [PATCH v2 1/3] aarch64: Remove a stray comment from opcode/aarch64.h

On 26/06/2026 16:41, Alice Carlotti wrote:
> On Fri, Jun 26, 2026 at 02:35:14PM +0100, Richard Earnshaw wrote:
>> When flag bit 28 was removed in an earlier patch, the comment describing
>> it was left behind.  This just cleans that up.
>> ---
>>  include/opcode/aarch64.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
>> index 6d1b414444a..f51045210c9 100644
>> --- a/include/opcode/aarch64.h
>> +++ b/include/opcode/aarch64.h
>> @@ -1479,7 +1479,7 @@ extern const aarch64_opcode aarch64_opcode_table[];
>>  #define F_OD(X) (((X) & 0x7) << 24)
>>  /* Instruction has the field of 'sz'.  */
>>  #define F_LSE_SZ (1 << 27)
>> -/* Require an exact qualifier match, even for NIL qualifiers.  */
>> +
>>  
>>  #define F_SYS_READ (1ULL << 29)
>>  /* This system instruction is used to write system registers.  */
>> -- 
>> 2.43.0
>>
> 
> The extra blank line looks unnecessary to me, but you'll be touching this again
> in the next patch anyway.  Ignoring that nit, this patch is obviously ok -
> thanks for fixing my earlier mistake.
> 
> Alice

I assumed it was deliberate to make it clear that there was a gap in the number system.  The gap gets closed in the next patch though...

R.