RE: [PATCH v1 2/2] Support x86 ACE ISA

> From: Jan Beulich <[email protected]>
> Sent: Tuesday, June 30, 2026 1:59 PM
> On 30.06.2026 05:17, Hu, Lin1 wrote:
> >> -----Original Message-----
> >> From: Ganesh Gopalasubramanian <[email protected]>
> >> Sent: Saturday, June 27, 2026 7:56 PM
> >>
> >> @@ -4253,6 +4257,7 @@ install_template (const insn_template *t)
> >>  	}
> >>
> >>        if ((maybe_cpu (t, CpuCMPCCXADD) || maybe_cpu (t, CpuAMX_TILE)
> >> +	   || maybe_cpu (t, CpuACE)
> >
> > Outer condition is if (t->opcode_modifier.vex && t->opcode_modifier.evex),
> seems that the line is invalid.
> 
> "invalid" as in "unnecessary"? Else please explain.
> 
> Also, as a general remark: Please trim reply context, especially when what you
> reply to was large.
>

Yes, it's unnecessary. ACE instructions don't set vex and evex at the same time.

BRs,
Lin