Re: [PATCH v3 01/13] RISC-V: add dedicated vector arithmetic .insn forms

Jan Beulich <[email protected]> Mon, 20 Jul 2026 07:59:50 +0200
Newsgroups gmane.comp.gnu.binutils
Message-ID <[email protected]>
On 19.07.2026 12:33, Nelson Chu wrote:
> LGTM +1.

Thanks for taking a look.

>  A minor thing (this patch is already good enough to me
> without any change) is do you think we need to define extra MASK/MATCH
> for funct3 to represent bits 10-12 rather than use 0x7000 directly?
> So that might make it immediately clear to understand what these
> values represent.

Personally I'm really of the opposite opinion: The huge amount of MASK /
MATCH pairs is clutter. See how e.g. aarch64-tbl.h gets away (almost?)
completely without. And it's (imo) better readable that way.

Jan