Re: [PATCH] testsuite: Also exclude `*-*-kfreebsd*-gnu' from STB_GNU_UNIQUE tests

On 21.07.2026 15:42, Maciej W. Rozycki wrote:
> On Tue, 21 Jul 2026, Jan Beulich wrote:
> 
>>> --- binutils-gdb.orig/binutils/testsuite/lib/binutils-common.exp
>>> +++ binutils-gdb/binutils/testsuite/lib/binutils-common.exp
>>> @@ -308,7 +308,7 @@ proc is_elf_unused_section_symbols {} {
>>>  # This require ELFOSABI_GNU, and `bfd_elf_final_link'.
>>>  #
>>>  proc supports_gnu_unique {} {
>>> -    if { [istarget *-*-freebsd*] } {
>>> +    if { [istarget *-*-freebsd*] || [istarget *-*-kfreebsd*-gnu] } {
>>
>> Is the -gnu at the end really needed here? If yes, it's okay as-is, but
>> preferably it would be put in without that tail.
> 
>  See bfd/config.bfd for how the targets are referred there; we obviously 
> need to stay consistent, because `foo-kfreebsd-bar' will choose different 
> BFD vectors (whether it makes sense or not, but that's not the matter of 
> this fix).

Afaict `foo-kfreebsd-bar' will simply not match anything, hitting the
"BFD does not support target" case. Therefore I don't see it as wrong to
have a wider match here than what bfd/config.bfd has. Yet no, I'm not
going to insist.

Jan