Re: [PATCH v3 1/1] aarch64: mingw: Prevent relocation types from being overwritten
Evgeny Karpov <[email protected]> Thu, 23 Jul 2026 12:03:10 +0200
| Newsgroups | gmane.comp.gnu.binutils |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 23 Jul 2026, Alan Modra wrote: > On Wed, Jul 22, 2026 at 10:34:08PM +0930, Alan Modra wrote: > > Firstly, is it really necessary? What exactly goes wrong with the > > current code? > > I am asking for some details on the following statement: > > > On Wed, Jul 22, 2026 at 01:04:00PM +0200, Evgeny Karpov wrote: > > > However, it impacts another relocation logic, as the initial relocation type > > > is no longer known. > > This is the patch I'll commit if you convince me. Thank you for the patch and for the suggestion. It was possible to change auto import implementation while looking for strong evidence by using a similar approach, rel->r_type = IMAGE_REL_ARM64_ABSOLUTE. It might change later, however for now it can stay like this. However as a personal opinion, "rel->r_type = IMAGE_REL_ARM64_ABSOLUTE" looks like a workaround and "rel->r_ignore = 1" looks more clear on what happens. Regards, Evgeny