Re: [PATCH 1/5] readelf: fold get_{32,64}bit_program_headers()
Jan Beulich <[email protected]> Mon, 27 Jul 2026 14:15:32 +0200
| Newsgroups | gmane.comp.gnu.binutils |
|---|---|
| Message-ID | <[email protected]> |
On 27.07.2026 14:12, H.J. Lu wrote: > On Mon, Jul 27, 2026 at 8:08 PM Jan Beulich <[email protected]> wrote: >> >> On 27.07.2026 13:56, Andreas Schwab wrote: >>> On Jul 27 2026, Jan Beulich wrote: >>> >>>> I did consider adding >>>> a new .c file, but I couldn't think of a name which I would be at least >>>> reasonably okay with. >>> >>> Perhaps following the pattern in bfd: readelf-nn.c >> >> And then also generate readelf-32.c and readelf-64.c from it? I'd like to >> avoid introducing new generated files, whenever possible. > > You don't need to generate readelf-32.c and readelf-64.c. > You can just include readelf-nn.c twice. Of course I can; the question was solely towards Andreas making an analogy with bfd/. Similar naming decisions may better (but don't need to) be used together with similar coding approaches. Jan