Re: [PATCH v1] Add support to recognise 32 bit core file formats in AIX 7.3

On Tue, Jul 28, 2026 at 03:06:33PM +0530, Aditya Vidyadhar Kamath wrote:
> diff --git a/bfd/rs6000-core.c b/bfd/rs6000-core.c
> index 0635960eaee..7edf639fc9a 100644
> --- a/bfd/rs6000-core.c
> +++ b/bfd/rs6000-core.c

This should likely be approved by one of the listed ppc binutils
maintainers.  I'm not an aix expert by any means.  That said the patch
looks OK to me with one small nit tidied.

> @@ -151,7 +151,9 @@ typedef union
>  
>  #ifdef AIX_5_CORE
>  # define CORE_DUMPXX_VERSION	267312562
> -# define CNEW_IS_CORE_DUMPXX(c) ((c).new_dump.c_version == CORE_DUMPXX_VERSION)
> +# define CORE_DUMPXX_VERSION_AIX73	267312561
> +# define CNEW_IS_CORE_DUMPXX(c) ((c).new_dump.c_version == CORE_DUMPXX_VERSION || \
> +				 (c).new_dump.c_version == CORE_DUMPXX_VERSION_AIX73)

Overlong lines, and trailing ||.  Rewrite as
# define CNEW_IS_CORE_DUMPXX(c) \
  ((c).new_dump.c_version == CORE_DUMPXX_VERSION		\
   || (c).new_dump.c_version == CORE_DUMPXX_VERSION_AIX73)

-- 
Alan Modra