[PATCH] x86-64: Return SHN_COMMON on non-ELF input

"H.J. Lu" <[email protected]> Thu, 30 Jul 2026 15:53:08 +0800
Newsgroups gmane.comp.gnu.binutils
Message-ID <CAMe9rOocK3FW8wp-pEeixfa_EnVTYbx30qmhBMbQFSJT_XCE_w@mail.gmail.com>
--000000000000123d5b0657cf5f10
Content-Type: text/plain; charset="UTF-8"

elf_x86_64_common_definition segfaults on PE/x86-64 input.  Return
SHN_COMMON on non-ELF input.  Linker now gets assertion fail at
bfd/coffgen.c:575, instead of getting segfault.

PR ld/34449
* elf64-x86-64.c (elf_x86_64_common_definition): Return
SHN_COMMON on non-ELF input.


-- 
H.J.

--000000000000123d5b0657cf5f10
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-x86-64-Return-SHN_COMMON-on-non-ELF-input.patch"
Content-Disposition: attachment; 
	filename="0001-x86-64-Return-SHN_COMMON-on-non-ELF-input.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_ms77uj291>
X-Attachment-Id: f_ms77uj291

RnJvbSBmYjcyZTg0ODNlNTUzMzNkZDY2ZjM5YzdhYjVkZjI1MDQxODEzM2JjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6
IFRodSwgMzAgSnVsIDIwMjYgMTU6NDc6MDUgKzA4MDAKU3ViamVjdDogW1BBVENIXSB4ODYtNjQ6
IFJldHVybiBTSE5fQ09NTU9OIG9uIG5vbi1FTEYgaW5wdXQKCmVsZl94ODZfNjRfY29tbW9uX2Rl
ZmluaXRpb24gc2VnZmF1bHRzIG9uIFBFL3g4Ni02NCBpbnB1dC4gIFJldHVybgpTSE5fQ09NTU9O
IG9uIG5vbi1FTEYgaW5wdXQuICBMaW5rZXIgbm93IGdldHMgYXNzZXJ0aW9uIGZhaWwgYXQKYmZk
L2NvZmZnZW4uYzo1NzUsIGluc3RlYWQgb2YgZ2V0dGluZyBzZWdmYXVsdC4KCglQUiBsZC8zNDQ0
OQoJKiBlbGY2NC14ODYtNjQuYyAoZWxmX3g4Nl82NF9jb21tb25fZGVmaW5pdGlvbik6IFJldHVy
bgoJU0hOX0NPTU1PTiBvbiBub24tRUxGIGlucHV0LgoKU2lnbmVkLW9mZi1ieTogSC5KLiBMdSA8
aGpsLnRvb2xzQGdtYWlsLmNvbT4KLS0tCiBiZmQvZWxmNjQteDg2LTY0LmMgfCAzICsrLQogMSBm
aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh
L2JmZC9lbGY2NC14ODYtNjQuYyBiL2JmZC9lbGY2NC14ODYtNjQuYwppbmRleCBmNDEyYjA3Njkz
My4uZTdlZmM2MjEwZDIgMTAwNjQ0Ci0tLSBhL2JmZC9lbGY2NC14ODYtNjQuYworKysgYi9iZmQv
ZWxmNjQteDg2LTY0LmMKQEAgLTYxMDUsNyArNjEwNSw4IEBAIGVsZl94ODZfNjRfY29tbW9uX2Rl
ZmluaXRpb24gKEVsZl9JbnRlcm5hbF9TeW0gKnN5bSkKIHN0YXRpYyB1bnNpZ25lZCBpbnQKIGVs
Zl94ODZfNjRfY29tbW9uX3NlY3Rpb25faW5kZXggKGFzZWN0aW9uICpzZWMpCiB7Ci0gIGlmICgo
ZWxmX3NlY3Rpb25fZmxhZ3MgKHNlYykgJiBTSEZfWDg2XzY0X0xBUkdFKSA9PSAwKQorICBpZiAo
YmZkX2dldF9mbGF2b3VyIChzZWMtPm93bmVyKSAhPSBiZmRfdGFyZ2V0X2VsZl9mbGF2b3VyCisg
ICAgICB8fCAoZWxmX3NlY3Rpb25fZmxhZ3MgKHNlYykgJiBTSEZfWDg2XzY0X0xBUkdFKSA9PSAw
KQogICAgIHJldHVybiBTSE5fQ09NTU9OOwogICBlbHNlCiAgICAgcmV0dXJuIFNITl9YODZfNjRf
TENPTU1PTjsKLS0gCjIuNTUuMAoK
--000000000000123d5b0657cf5f10--