Re: [PATCH] ld: testsuite: Declare the section in ld/testsuite/ld-gc/dummy.s correctly.
Jan Beulich <[email protected]>
| Newsgroups | gmane.comp.gnu.binutils |
|---|---|
| Message-ID | <[email protected]> |
On 12.08.2026 09:35, Jan Dubiec wrote: > On 12.08.2026 09:01, Jan Beulich wrote: >> On 10.08.2026 01:38, Jan Dubiec wrote: >>> --- a/ld/testsuite/ld-gc/dummy.s >>> +++ b/ld/testsuite/ld-gc/dummy.s >>> @@ -1,2 +1,2 @@ >>> # Dummy >>> - .section ".note.GNU-stack" >>> + .section ".note.GNU-stack", "" >> >> Besides ELF, for COFF this looks to be okay, but apparently not for e.g. Mach-O? >> Is our Mach-O support broken enough to simply not care? >> >> And then, don't two of the files under ld-unique/ have the same issue? > They have. And the patch has been sitting in my queue for three days. :-) > > Speaking of Mach-O and ld-unique/, unique.s already defines that section > this way. ld-unique/ tests nothing for non-ELF aiui, so can't be used as a reference for what's done in ld-gc/, I'm afraid. Jan