RE: [PATCH] x86: rename avx10.1aux to avx10v1aux
"Jiang, Haochen" <[email protected]>
| Newsgroups | gmane.comp.gnu.binutils |
|---|---|
| Message-ID | <SJ5PPF77D28E3C2E95B9BB088C0931CB228ECA52@SJ5PPF77D28E3C2.namprd11.prod.outlook.com> |
> From: Jan Beulich <[email protected]> > Sent: Wednesday, August 19, 2026 4:37 PM > > On 19.08.2026 10:34, Jiang, Haochen wrote: > >> From: Rohan Shenoy <[email protected]> > >> Sent: Wednesday, August 19, 2026 4:18 PM > >> > >> diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c > >> index 1ce5a063c67..b41eeeddc71 100644 > >> --- a/gas/config/tc-i386.c > >> +++ b/gas/config/tc-i386.c > >> @@ -1253,7 +1253,7 @@ static const arch_entry cpu_arch[] = > >> VECARCH (sm4, SM4, ANY_SM4, reset), > >> SUBARCH (pbndkb, PBNDKB, PBNDKB, false), > >> VECARCH (avx10.1, AVX10_1, ANY_AVX512F, set), > >> - VECARCH (avx10.1aux, AVX10_1_AUX, ANY_AVX10_1_AUX, set), > >> + VECARCH (avx10v1aux, AVX10_1_AUX, ANY_AVX10_1_AUX, set), > > > > Should we also change from AVX10_1_AUX to AVX10V1AUX and also > > for cpu bit name avx10_1_aux to avx10v1aux? > > If at all, only to avx10_v1_aux / AVX10_V1_AUX imo, to keep the identifiers > readable. I'd question to value of the added 'v' / 'V' though. > Oh. Mine. Jan is right here. I messed GCC option naming trend with Binutils since I am actively working on GCC patches recently. It should be avx10_v1_aux and AVX10_V1_AUX. Thx, Haochen