Re: [PATCH 3/3] gas: re-use config/te-*.h
"Maciej W. Rozycki" <[email protected]>
| Newsgroups | gmane.comp.gnu.binutils |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 21 Aug 2026, Jan Beulich wrote: > --- a/gas/config/te-tmips.h > +++ b/gas/config/te-tmips.h > @@ -20,21 +20,10 @@ > > /* This file is te-tmips.h and is intended to provide support for > traditional mips targets like mips-dde-sysv4.2MP (Supermax ) , > - mips-sni-sysv4* (Sinix) etc. The base for this file is te-generic.h. > + mips-sni-sysv4* (Sinix) etc. > Created by Koundinya.K < [email protected] > with the help of > Ian Lance Taylor, Cygnus Support, <[email protected]>. */ > > -/* Added these, because if we don't know what we're targeting we may > - need an assembler version of libgcc, and that will use local > - labels. */ > - > #define TE_TMIPS 1 > -#define LOCAL_LABELS_DOLLAR 1 > -#define LOCAL_LABELS_FB 1 > > -/* these define interfaces */ > -#ifdef OBJ_HEADER > -#include OBJ_HEADER > -#else > -#include "obj-format.h" > -#endif > +#include "te-generic.h" This seems good if not obvious to me, and didn't cause any regressions across my usual set of MIPS targets. Obviously none of the `mips*-*-sysv*' is supported anymore, so I'll have to update the comment accordingly, and e.g. gas/configure.tgt asks for an update as well. Thank you for doing this cleanup. Maciej