Re: [PATCH] x86: support further AMD Zen6 instructions
Jan Beulich <[email protected]>
| Newsgroups | gmane.comp.gnu.binutils |
|---|---|
| Message-ID | <[email protected]> |
On 01.09.2026 11:15, Rohan Shenoy wrote:
> Changes:
> - Add support for RMPOPT and RMPCHKD instructions.
> - Enable FRED on znver6.
> ---
> gas/config/tc-i386.c | 2 ++
> gas/doc/c-i386.texi | 5 +++-
> gas/testsuite/gas/i386/rmpchkd.d | 16 ++++++++++++
> gas/testsuite/gas/i386/rmpchkd.s | 9 +++++++
> gas/testsuite/gas/i386/rmpopt.d | 16 ++++++++++++
> gas/testsuite/gas/i386/rmpopt.s | 9 +++++++
> gas/testsuite/gas/i386/x86-64-arch-6-znver6.d | 4 +++
> gas/testsuite/gas/i386/x86-64-arch-6.d | 4 +++
> gas/testsuite/gas/i386/x86-64-arch-6.s | 4 +++
> gas/testsuite/gas/i386/x86-64.exp | 2 ++
> opcodes/i386-dis.c | 25 ++++++++++++++++++-
> opcodes/i386-gen.c | 8 +++++-
> opcodes/i386-opc.h | 6 +++++
> opcodes/i386-opc.tbl | 12 +++++++++
> 14 files changed, 119 insertions(+), 3 deletions(-)
> create mode 100644 gas/testsuite/gas/i386/rmpchkd.d
> create mode 100644 gas/testsuite/gas/i386/rmpchkd.s
> create mode 100644 gas/testsuite/gas/i386/rmpopt.d
> create mode 100644 gas/testsuite/gas/i386/rmpopt.s
Looks largely okay, just one comment:
> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl
> @@ -3205,6 +3205,18 @@ rmpread, 0xf20f01fd, RMPREAD&x64, IsString|NoSuf|NoRex64, { Acc|Qword, RegC|Unsp
>
> // RMPREAD instruction end
>
> +// RMPCHKD instruction
> +
> +rmpchkd, 0xf30f01fc, RMPDIRTY&x64, NoSuf, {}
> +
> +// RMPCHKD instruction end
> +
> +// RMPOPT instruction
> +
> +rmpopt, 0xf20f01fc, RMPOPT&x64, NoSuf, {}
> +
> +// RMPOPT instruction end
Like other RMP* insns, these take operands in fixed registers. Hence like
those other RMP* insns I think explicitly specifying the operands should
be permitted, also allowing to control some insn prefix(es) that way.
Jan