RE: [PATCH] x86: support further AMD Zen6 instructions

> From: Rohan Shenoy <[email protected]>
> Sent: Tuesday, September 1, 2026 5:16 PM
> 

LGTM but with two minor comments.

> Changes:
> - Add support for RMPOPT and RMPCHKD instructions.
> - Enable FRED on znver6.

Could you show me the documentation for that?

> diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c
> index b8d7ad2b0b1..cf37d8786e9 100644
> --- a/opcodes/i386-gen.c
> +++ b/opcodes/i386-gen.c
> @@ -261,6 +261,10 @@ static const dependency isa_dependencies[] =
>      "SNP|64" },
>    { "RMPREAD",
>      "SNP|64" },
> +  { "RMPDIRTY",
> +    "SNP|64" },
> +  { "RMPOPT",
> +    "SNP|64" },

Since you have implied x64 here ...

>    { "TSX",
>      "RTM|HLE" },
>    { "TSXLDTRK",
> diff --git a/opcodes/i386-opc.tbl b/opcodes/i386-opc.tbl
> index 413ad4f2879..9a32636d0e5 100644
> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl
> @@ -3205,6 +3205,18 @@ rmpread, 0xf20f01fd, RMPREAD&x64,
> IsString|NoSuf|NoRex64, { Acc|Qword, RegC|Unsp
> 
>  // RMPREAD instruction end
> 
> +// RMPCHKD instruction
> +
> +rmpchkd, 0xf30f01fc, RMPDIRTY&x64, NoSuf, {}
> +
> +// RMPCHKD instruction end
> +
> +// RMPOPT instruction
> +
> +rmpopt, 0xf20f01fc, RMPOPT&x64, NoSuf, {}
> +

... I believe we do not need the x64 here. They are redundant.

Thx,
Haochen

> +// RMPOPT instruction end
> +
>  // RDPRU instruction
> 
>  rdpru, 0x0f01fd, RDPRU, NoSuf, {}
> --
> 2.34.1