Re: CryptoContext: uninitialized value

------=_Part_293334_1131205841.1335811859227
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

----- Original Message -----
> From: "Werner Dittmann" <[email protected]>
> To: [email protected]
> Sent: Monday, April 30, 2012 3:11:37 AM
> Subject: Re: [Ccrtp-devel] CryptoContext: uninitialized value
> 
> Initialization to NULL is correct. In case of non-authentication mode
> this could
> lead to problems if macCtx contains some random value and delete uses
> this value
> to free the macCtx.

In that case, could the attached patch be applied?

Best,
Tristan

> 
> This problem did not show up because SRTP usually uses an
> authentication mode and
> macCtx was initialized eventually. Note: SRTP shall always use an
> authentication.
> 
> Regards,
> Werner
> 
> Am 30.04.2012 03:45, schrieb Tristan Matthews:
> > [Apologies for cross-posting...accidentally mailed this to
> > bug-commoncpp]
> > 
> > I was just wondering if macCtx in CryptoCtx is deliberately _not_
> > initialized in either of CryptoContext's constructors.
> > I ask because this value is used in an if-statement in the
> > destructor for CryptoContext (see CryptoContext.cpp:180).
> > Note that the body of the if-statement checks against initialized
> > values before doing any work, so the current code is harmless.
> > 
> > Best,
> > Tristan
> > 
> 
> 
> _______________________________________________
> Ccrtp-devel mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/ccrtp-devel
> 

------=_Part_293334_1131205841.1335811859227
Content-Type: text/x-patch; name=crypto_context.patch
Content-Disposition: attachment; filename=crypto_context.patch
Content-Transfer-Encoding: base64

RnJvbSA2ZGRmMjg1MTAxZWU1MmMxM2UyYzVkNTUxYTdmZmU5NzA5YTkzN2JmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIE1hdHRoZXdzIDx0cmlzdGFuLm1hdHRoZXdzQHNh
dm9pcmZhaXJlbGludXguY29tPgpEYXRlOiBGcmksIDI3IEFwciAyMDEyIDE1OjI1OjM0IC0wNDAw
ClN1YmplY3Q6IFtQQVRDSCAxLzFdIERlZmF1bHQgaW5pdGlhbGl6ZSBtYWNDdHggdG8gTlVMTAoK
LS0tCiBzcmMvQ3J5cHRvQ29udGV4dC5jcHAgfCAgICA0ICsrLS0KIDEgZmlsZXMgY2hhbmdlZCwg
MiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9DcnlwdG9D
b250ZXh0LmNwcCBiL3NyYy9DcnlwdG9Db250ZXh0LmNwcAppbmRleCA5Mzk2NDYyLi44NTJjNTM3
IDEwMDY0NAotLS0gYS9zcmMvQ3J5cHRvQ29udGV4dC5jcHAKKysrIGIvc3JjL0NyeXB0b0NvbnRl
eHQuY3BwCkBAIC01MSw3ICs1MSw3IEBAIG1hc3Rlcl9zYWx0KE5VTEwpLCBtYXN0ZXJfc2FsdF9s
ZW5ndGgoMCksCiBuX2UoMCksa19lKE5VTEwpLG5fYSgwKSxrX2EoTlVMTCksbl9zKDApLGtfcyhO
VUxMKSwKIGVhbGcoU3J0cEVuY3J5cHRpb25OdWxsKSwgYWFsZyhTcnRwQXV0aGVudGljYXRpb25O
dWxsKSwKIGVrZXlsKDApLCBha2V5bCgwKSwgc2tleWwoMCksCi1zZXFOdW1TZXQoZmFsc2UpLCBj
aXBoZXIoTlVMTCksIGY4Q2lwaGVyKE5VTEwpCitzZXFOdW1TZXQoZmFsc2UpLCBtYWNDdHgoTlVM
TCksIGNpcGhlcihOVUxMKSwgZjhDaXBoZXIoTlVMTCkKIHt9CiAKICNpZmRlZiBTUlRQX1NVUFBP
UlQKQEAgLTczLDcgKzczLDcgQEAgc3NyY0N0eChzc3JjKSx1c2luZ19ta2koZmFsc2UpLG1raUxl
bmd0aCgwKSxta2koTlVMTCksCiByb2Mocm9jKSxndWVzc2VkX3JvYygwKSxzX2woMCksa2V5X2Rl
cml2X3JhdGUoa2V5X2Rlcml2X3JhdGUpLAogcmVwbGF5X3dpbmRvdygwKSwKIG1hc3Rlcl9rZXlf
c3J0cF91c2VfbmIoMCksIG1hc3Rlcl9rZXlfc3J0Y3BfdXNlX25iKDApLCBzZXFOdW1TZXQoZmFs
c2UpLAotY2lwaGVyKE5VTEwpLCBmOENpcGhlcihOVUxMKQorbWFjQ3R4KE5VTEwpLCBjaXBoZXIo
TlVMTCksIGY4Q2lwaGVyKE5VTEwpCiB7CiAgICAgdGhpcy0+ZWFsZyA9IGVhbGc7CiAgICAgdGhp
cy0+YWFsZyA9IGFhbGc7Ci0tIAoxLjcuNS40Cgo=
------=_Part_293334_1131205841.1335811859227
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ccrtp-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/ccrtp-devel

------=_Part_293334_1131205841.1335811859227--