bug#47243: pr lacks -p
Pádraig Brady <[email protected]>
| Newsgroups | gmane.comp.gnu.core-utils.bugs |
|---|---|
| Message-ID | <[email protected]> |
On 28/07/2025 11:22, Pádraig Brady wrote: > On 28/07/2025 03:21, Collin Funk wrote: >> Hi Paul, >> >> Paul Eggert <[email protected]> writes: >> >>> Thanks for looking into that. Unfortunately POSIX says -p should be >>> ignored only if standard output is a terminal, and that newline should >>> be read from /dev/tty, not from standard input. This is so that users >>> can pipe into 'pr -p'. So the proposed patch needs some changes. Here >>> are the issues I found: >> >> Thanks for the thorough review. >> >> I think that v3 attached should cover everything. >> >> Collin >> > > write_error() manipulates stdout, > so for the putc(..., stderr) I'd just do a straight error(EXIT_FAILURE, ....) > > The NEWS would be best in a "New Features" section. > > thanks! > Padraig Reading POSIX more closely I see there is also pause logic for the first page only: -f [XSI] [Option Start] Use a <form-feed> for new pages, instead of the default behavior that uses a sequence of <newline> characters. Pause before beginning the first page if the standard output is associated with a terminal. [Option End]