bug#79336: [PATCH] df: fix potential null pointer dereference

yubiao hu <[email protected]>
Newsgroups gmane.comp.gnu.core-utils.bugs
Message-ID <CADzWzW_K+DqnO2HJwfhZM4GftmE9R+xBpgjzzq=EYGoJUB+bKQ@mail.gmail.com>
> On 2025-08-28 18:45, yubiao hu wrote:
>> * src/df.c (get_dev): Fix potential null pointer dereference
>> - Avoid dereferencing stat_file when both device and
>>   mount_point are NULL
>> - Handle allocation failure for cell when mount_point
>>   is NULL
>
> Why is this patch needed? Can you give an example df invocation in which
> mount_point is null there? As far as I can see, that cannot happen.
>
> Did your bug report come from static analysis? If so, which static
> analyzer did you use and how did you use it? Does the attached patch
> pacify your static analyzer?

Yes, this bug was identified via static code analysis. The initial
finding that core dump would occur in `cell = xstrdup (mount_point);`
when mount_point is NULL.

I attempted to inject code to set the mount_point of get_dev() to
NULL, which still results in a core within IS_ABSOLUTE_FILE_NAME.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.