bug#79567: [PATCH] maint: pacify -Werror=trailing-whitespace

Collin Funk wrote:
> Grisha Levit <[email protected]> writes:
> 
> > There is code [1] in gnulib that disables this warning for config.h but
> > it is meant to be temporary and once removed would cause this snippet to
> > trigger a failure.
> >
> > [1] https://cgit.git.savannah.gnu.org/cgit/gnulib.git/commit/?id=ff19eeafbee
> 
> Was it supposed to be temporary?

The comment says it:

  dnl This is a temporary workaround until Autoconf fixes it.
  dnl Test case:
  dnl empty1=; empty2=; AC_DEFINE_UNQUOTED([FOO], [$empty1$empty2], [...])
  dnl should produce "#define FOO /**/", not "#define FOO ".

IIRC, I have not reported it to the Autoconf mailing list. So, if you
want to do that, please do!

But Grisha is right: Once Autoconf gets these #define lines right,
without trailing whitespace, Gnulib's added
  # pragma GCC diagnostic ignored "-Wtrailing-whitespace"
will go away. Therefore his patch is correct. The essential change
being to remove the two spaces from the line with
  ])

Bruno