Re: [PATCH] find: add bison as a requirement for compiling

Hi Berny,

Thanks for the tweak, lgtm.

-Dave

On Tue, Sep 17, 2024 at 1:40 AM Bernhard Voelker
<[email protected]> wrote:
>
> Hi Dave,
>
> On 9/13/24 10:12, Dave wrote:
> >  From 2a83f217df3469eec4226255ab9d27251dd8f2ba Mon Sep 17 00:00:00 2001
> > From: Dave <[email protected]>
> > Date: Fri, 13 Sep 2024 07:53:31 +0000
> > Subject: [PATCH] find: add bison as a requirement for compiling
> >
> > *README-hacking(prerequisites): Compiling without bison would result in
> > `fatal error: parse-datetime.c: No such file or directory` which is not
> > a very helpful error message.
> > ---
> >   README-hacking | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/README-hacking b/README-hacking
> > index 0d96dc84..13f91b3d 100644
> > --- a/README-hacking
> > +++ b/README-hacking
> > @@ -17,6 +17,7 @@ Prerequisites
> >    * GNU m4
> >    * GNU gettext
> >    * GNU Dejagnu
> > + * GNU Bison
> >
> >   Dejagnu is in fact optional, but it's strongly recommended, since it is
> >   needed to run findutils' test suite (which is how you know that find
>
> many thanks for the report.
>
> Additionally to just adding Bison to maintainer README, I'd also add it
> as a real prerequisite for the bootstrap process by gnulib, so that the
> build would fail much earlier:
>
>    $ ./bootstrap
>    ./bootstrap: Error: 'bison' not found
>    ./bootstrap: Please install the prerequisite programs
>
> I've tweaked the patch and would push the attached in your name, if you agree.
>
> Thanks & have a nice day,
> Berny