Re: new module 'hasmntopt'

On 8/19/24 5:23 PM, Bruno Haible wrote:
> 2024-08-19  Bruno Haible  <[email protected]>
...
> 	hasmntopt: New module.
...
>
> 2024-08-19  Bruno Haible  <[email protected]>
>
> 	mntent: New module.

While trying to update gnulib in findutils, I've been prompted by this new syntax-check failure:

   find/fstype.c:30:#if HAVE_MNTENT_H
   maint.mk: do not test the above HAVE_<header>_H symbol(s);
     with the corresponding gnulib module, they are always true
   make: *** [maint.mk:969: sc_prohibit_always_true_header_tests] Error 1

When trying to use the new 'mntent' module (alone), I'm getting the following error:

   ./mntent.h:584:6: error: operator '&&' has no left operand
     584 | #if  && 1
         |      ^~

It seems that it's not possible to use 'mntent' without also using 'hasmntopt'.
because only the latter defines @GNULIB_HASMNTOPT@ and added it to mntent.in.h:

   #if @GNULIB_HASMNTOPT@ && @HAVE_SETMNTENT@

Reproducer:

   $ ./gnulib-tool --create-testdir --dir=/tmp/testdir mntent \
        && cd /tmp/testdir \
        && ./configure && make

... yields in gllib/mntent.h:584:

   #if  && 1

Should 'mntent' depend on 'hasmntopt' (which would be a circular dependency)?
Is there another solution?

Have a nice day,
Berny