Re: [PATCH] Simplify lib/listfile.c.
Bernhard Voelker <[email protected]> Sun, 12 Jul 2026 16:59:45 +0200
| Newsgroups | gmane.comp.gnu.findutils.patches,gmane.comp.gnu.findutils.bugs |
|---|---|
| Message-ID | <[email protected]> |
Hi James,
On 7/11/26 12:30, James Youngman wrote:
> * lib/listfile.c (list_file): factor out most of the logic.
> * bootstrap.conf (gnulib_modules): add inttotr (which is now used in
> lib/listfile.c).
oh, something went wrong here I assume.
This commit introduces a regression for the output of 'find -ls':
$ touch file1 file2
$ /usr/bin/find file1 file2 -ls
5777714 0 -rw-r--r-- 1 berny users 0 Jul 12 16:45 f=
ile1
5777715 0 -rw-r--r-- 1 berny users 0 Jul 12 16:45 f=
ile2
$ find/find file1 file2 -ls
5777714 0-rw-r--r-- 1 berny users 0 Jul 12 16:45 =
5777715 0-rw-r--r-- 1 berny=20
users 0 Jul 12 16:45 $
- missing filename.
- missing newline at the end of each entry.
- missing space before the permission string.
- different spacing in other places (compared to before).
Interestingly, only one test of the testsuite fails:
FAIL: tests/find/readdir_race.sh
Was there a local merge issue?
Have a nice day,
Berny