Re: [PATCH 2/3] lib: extract decimal_absval_add_one for use as a library function.

On 7/22/26 01:01, James Youngman wrote:

...

> diff --git a/lib/add-one.c b/lib/add-one.c
> new file mode 100644
> index 00000000..ad2a9c72
> --- /dev/null
> +++ b/lib/add-one.c
> @@ -0,0 +1,48 @@
> +/* getlimits - print various platform dependent limits.

better "add-one ...".

> +   Copyright (C) 2023-2026 Free Software Foundation, Inc.

not sure if the Copyright year number starts fresh if we say below
that this was factored out from getlimits which in turn was brought in
from coreutils?

> +   This program is free software: you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation, either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <https://www.gnu.org/licenses/=
>.  */
> +
> +/* Based on 'getlimits' of GNU coreutils, written by P=C3=A1draig Brady=
.
> + * Stripped down to a minimal version by Bernhard Voelker.  */

", and now factored out into this add-one.c by James Youngman." ?


> diff --git a/lib/add-one.h b/lib/add-one.h
> new file mode 100644
> index 00000000..ef0351b8
> --- /dev/null
> +++ b/lib/add-one.h
> @@ -0,0 +1,22 @@
> +/* getlimits - print various platform dependent limits.

Likewise here.

Otherwise +1.

Thanks & have a nice day,
Berny