Re: CMake Integration
Petra Millarova <[email protected]> Mon, 21 Oct 2019 12:09:37 -0400
| Newsgroups | gmane.comp.gnu.gama.bugs |
|---|---|
| Message-ID | <CAA1GP57+pur0CG=TcvaK1hSz9GikeJ8F7-5LW5XO5y-SOqzfhA@mail.gmail.com> |
--===============7102253562714331564== Content-Type: multipart/alternative; boundary="0000000000009d0af305956de9fa" --0000000000009d0af305956de9fa Content-Type: text/plain; charset="UTF-8" Hi everyone! First of all, thank you for the contributions Vasileios! You have a valid point in the fact that using one build system would be better than two. After some research, it seems that Visual Studio actually started to support MinGW - at least to some extent. ( https://devblogs.microsoft.com/cppblog/using-mingw-and-cygwin-with-visual-cpp-and-open-folder/) I plan on trying it out later this week, I will let you know what I have found out, I think it might be good to use autotools only if there were no major problems with it in VS, it would certainly make it simpler. P. On Sun, 20 Oct 2019 at 20:04, Greg Troxel <[email protected]> wrote: > I should explain one of my comments further. > > In auto*, the notion is that the configure code should test for a > feature, such as a library existing, or a header, or if some sample code > can be compiled. None of this should ask "what OS am I on", so that > when it's built on a not previously contemplated OS, it just works. > > cmake may have the same notion. But almost always when I deal with > packages that have cmake build systems and that do not actually build (on > the system I am building them on), I see a lot of conditionals about OS > type. > > So I'd say that if the cmake code has "if this is a mac, do X", or > similar, that's a bug and should be removed, in favor of a feature test. > > Of course, another view is that the cmake build should be only for > windows, in which case > > if this os is not windows > throw an error > > is a good approach. > > > > --0000000000009d0af305956de9fa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi everyone!=C2=A0<br>First of all, thank you for the cont= ributions=C2=A0Vasileios! You have a valid point in the fact that using one= build system would be better than two. After some research, it seems that = Visual Studio actually started to support MinGW - at least to some extent.= =C2=A0 (<a href=3D"https://devblogs.microsoft.com/cppblog/using-mingw-and-c= ygwin-with-visual-cpp-and-open-folder/">https://devblogs.microsoft.com/cppb= log/using-mingw-and-cygwin-with-visual-cpp-and-open-folder/</a>) I plan on = trying it out later this week, I will let you know what I have found out, I= think it might be good to use autotools only if there were no major proble= ms with it in VS, it would certainly make it simpler.=C2=A0<br><br>P.</div>= <br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun= , 20 Oct 2019 at 20:04, Greg Troxel <<a href=3D"mailto:[email protected]">g= [email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_quote" sty= le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi= ng-left:1ex">I should explain one of my comments further.<br> <br> In auto*, the notion is that the configure code should test for a<br> feature, such as a library existing, or a header, or if some sample code<br= > can be compiled.=C2=A0 None of this should ask "what OS am I on",= so that<br> when it's built on a not previously contemplated OS, it just works.<br> <br> cmake may have the same notion.=C2=A0 =C2=A0 But almost always when I deal = with<br> packages that have cmake build systems and that do not actually build (on<b= r> the system I am building them on), I see a lot of conditionals about OS<br> type.<br> <br> So I'd say that if the cmake code has "if this is a mac, do X"= ;, or<br> similar, that's a bug and should be removed, in favor of a feature test= .<br> <br> Of course, another view is that the cmake build should be only for<br> windows, in which case<br> <br> if this os is not windows<br> =C2=A0 throw an error<br> <br> is a good approach.<br> <br> <br> <br> </blockquote></div> --0000000000009d0af305956de9fa-- --===============7102253562714331564== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQnVnLWdhbWEg bWFpbGluZyBsaXN0CkJ1Zy1nYW1hQGdudS5vcmcKaHR0cHM6Ly9saXN0cy5nbnUub3JnL21haWxt YW4vbGlzdGluZm8vYnVnLWdhbWEK --===============7102253562714331564==--