Re: cmdline_file_save accepts file handler instead

"Papp Gyozo (VBuster)" <[email protected]> Thu, 18 Oct 2007 18:39:39 +0200
Newsgroups gmane.comp.gnu.gengetopt.general
Message-ID <[email protected]>
Hi,

I debugged it but up to now I don't know what is wrong with.
I made make clean && make check in the gengetopt 2.21 tests directory, log attached.

I found only one FAILED test: test_conf_parser_err_string.sh and not the one Lorenzo mentioned below:

> > concerning the patch for config file, my tests for config file parsers
> fail:
> > 
> > test_conf_parser:./test_conf.conf:7: malformed string in configuration
> file
> > FAIL: test_conf_parser.sh
> > could you please check this?

test_conf_parser_err_string.sh contains two test cases (attached):
- first the test_conf_parser sample is executed on test_conf_err_string.conf
- if it passes the previous test(!) then it will be tested against test_conf_err_string2.conf

Each test_conf file contains malformed strings.

I suspect that the second testcase had never ran before. Before applying my patch gengetopt rejected lines similar to this one from test_conf_err_string.conf

multi-string = mal"formed"

My patch accepts this argument and treated as a valid string value as is (mal"formed") for the option 'multi-string'. That's why the next never executed testcase will fire, too, but it contains an invalid string value:

multi-string = "unterminated

I really hope I shed some light now. Is there any other volunteer to confirm my experience?