Re: [PATCH] libutil: find: Define PATH_MAX for GNU/Hurd systems.

Hello,

On 06/29/16 02:28, Shigio YAMAGUCHI wrote:
> I change my opinion. I'd like to leave this problem for porters.
> We cannot say a certain thing about platforms which don't have PATH_MAX.
> Those who want to port GLOBAL to such platforms should set PATH_MAX to
> an appropriate value.
> I would like to add code as follows:
> 
> #ifndef PATH_MAX
> Since this platform does not have PATH_MAX, you should define it
> using an appropriate value for the platform.
> /* #define PATH_MAX     1024 */
> #endif
> 
> What do you think?
> 

I see your point and I am okay with this approach.

Thank you,
Manolis

_______________________________________________
Bug-global mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-global

diff --git a/libutil/find.h b/libutil/find.h
index 45e3603..519a1ba 100644
--- a/libutil/find.h
+++ b/libutil/find.h
@@ -21,6 +21,12 @@
 #ifndef _FIND_H_
 #define _FIND_H_
 
+#ifndef PATH_MAX
+/* Since this platform does not have PATH_MAX, you should define it
+   using an appropriate value for the platform. */
+/* #define PATH_MAX     1024 */
+#endif
+
 void set_accept_dotfiles(void);
 void set_skip_unreadable(void);
 int skipthisfile(const char *);