Re: --from-here and --literal options do not interact

Hi,
I committed your patch as a bug fix.
Thank you.

Regards,
Shigio


2017-09-20 19:38 GMT+09:00 Jonathan Jacobs <[email protected]>:

> Good day,
>
> In an attempt to improve support in the emacs library, ggtags, for
> symbols named with lisp conventions such as "earmuffs" (surrounded by
> asterisks, such as *some-variable*) I noticed that the handling for
> the --from-here option does not interact with the --literal option:
>
> $ global -v --result=grep --color=always --path-style=shorter
> --from-here=77:emulator/beam/erl_process.c -x --literal -- '*ok*'
> global: regular expression is not allowed with the --from-here option.
>
> The man page doesn't go into any detail other than to say "Regular
> expression is not allowed for pattern." However the intent of the
> --literal option is to indicate that the search term is in fact not a
> regular expression.
>
> I've attached a patch that I think might enable the use of --literal
> with --from-here, it seems the rest of the code in this path will
> treat it literally without additional code although I lack the
> expertise required to confirm that.
>
> Regards,
> Jonathan Jacobs
>
> _______________________________________________
> Bug-global mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/bug-global
>
>


-- 
Shigio YAMAGUCHI <[email protected]>
PGP fingerprint:
26F6 31B4 3D62 4A92 7E6F  1C33 969C 3BE3 89DD A6EB

_______________________________________________
Bug-global mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-global