Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Simon Josefsson via Bug reports for the GNU Internet utilities <[email protected]> Fri, 08 Jul 2022 09:51:28 +0200

Newsgroups	gmane.comp.gnu.inetutils.bugs
Message-ID	<[email protected]>

Erik Auerswald <[email protected]> writes:

> I'll try to look into this over the weekend, but I cannot promise
> anything.  But this patch series should just address the same issues
> as the patches I sent before, perhaps with some smaller differences.
> It's been some time and I do not remember all the details.

I have merged your NEWS entries now.  There are some remaining patches
that aren't committed, but I'm not sure they are as critical anymore and
if we change ancient code it should preferably come with a self-check
that excercise the code path.

>> Btw, it is generally preferrably to have one commit solve one bug
>> report instead of doing several bug reports in one commit like your
>> proposed patch did.
>
> Yes, I agree.  I rolled everything up into three mostly independent
> patches to make it easier for me to maintain the patches externally,
> and to need to write less commit messages. ;-)

Do you maintain your patchset publicly, or for internal uses only?

/Simon

signature.asc (application/pgp-signature, 255 B)