Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Simon Josefsson via Bug reports for the GNU Internet utilities <[email protected]> Fri, 08 Jul 2022 11:49:57 +0200

Newsgroups	gmane.comp.gnu.inetutils.bugs
Message-ID	<[email protected]>

Erik Auerswald <[email protected]> writes:

> I want to look at your new tests, perhaps I can learn how to add some
> tests to verify the genget() functionality.

The test suite today is rather limited, as you probably have noticed,
but going forward it would really help if we created a self-check that
triggers a bug we want to solve, and then confirm that it actually fails
during build, and then succeeds after patching the bug.

You may want to look at NixOS or GitLab CI/CD for build failures:
https://hydra.nixos.org/jobset/gnu/inetutils-master
https://gitlab.com/jas/inetutils/-/pipelines
The GitLab recipe is here:
https://gitlab.com/jas/inetutils-cicd/-/blob/master/inetutils.yml
I'm not that familiar with NixOS but noticed now that builds fail.

>> Do you maintain your patchset publicly, or for internal uses only?
>
> It is publicly available at:
> https://www.unix-ag.uni-kl.de/~auerswal/gnu-inetutils/

Crystal clear, thank you!  Hopefully we can merge any more patches you
create a bit quicker, or you can do so yourself -- although initially
please wait for review before committing anything.

/Simon

signature.asc (application/pgp-signature, 255 B)