Re: memset_explicit: Fix compilation error on some OpenSolaris derivatives

Simon Josefsson via Bug reports for the GNU Internet utilities <[email protected]> Wed, 24 Apr 2024 15:22:09 +0200

Newsgroups	gmane.comp.gnu.inetutils.bugs,gmane.comp.lib.gnulib.bugs
Message-ID	<[email protected]>

Collin Funk <[email protected]> writes:

> Hi Paul,
>
> On 4/23/24 11:22 PM, Paul Eggert wrote:
>> Why is telnetd.h including config.h? Only a top-level C file should
>> include config.h, and it should so so at the start.
>
> I don't disagree. Most of those lines are 20 years old, so I assume it
> wasn't a problem then. Though I do wonder how common those warnings
> would be in other projects.

I think this was fairly common before.  If there had been a 'make
syntax-check' rule for this, we would have caught it!  I have removed
use of HAVE_CONFIG_H and fixed telnetd.h in Inetutils now, thanks.

https://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=32336c79b6aede7beef1d6929b631a53d141cee6
https://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=c7f6910d6832d90be59033911a39de2d4b59de30

/Simon

signature.asc (application/pgp-signature, 255 B)