Re: ifconfig: Fix ASAN 'dynamic-stack-buffer-overflow' in formatting.

Simon Josefsson via Bug reports for the GNU Internet utilities <[email protected]> Tue, 07 May 2024 09:25:45 +0200
Newsgroups gmane.comp.gnu.inetutils.bugs
Message-ID <[email protected]>
Collin Funk <[email protected]> writes:

> On 5/6/24 6:03 PM, Collin Funk wrote:
>> So I am confident it is a bug. I've applied the attached patch which
>> seems to fix the issue. This is based on a quick glance of the code so
>> I would appreciate others looking it over. Thanks!

Thank you!  I think we should figure out how to run ASAN builds via
CI/CD to catch regression of bugs like this.

> Oops, I forgot to run 'make indent', sorry...
> I'll just leave it for now in case a NEWS entry should also be added
> for this change. I'm not too sure how that works.

Yes please indent code and write a NEWS entry about fixing some ASAN
alarms.

/Simon
signature.asc (application/pgp-signature, 255 B)
-----BEGIN PGP SIGNATURE-----

iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCZjnXeRQcc2ltb25Aam9z
ZWZzc29uLm9yZwAKCRBRcisI/kdFovK8AP4gZgZdDwocx6FjJIDjH/CY8CbAj6n/
ZGoHrZEVvRhhvAEAuS4+6hXO6RAMQNosRifSYmrWsmxiruZfiPfY6JaYJwg=
=VFlQ
-----END PGP SIGNATURE-----