Re: ping, ping6: Fix mistake in previous change.

Simon Josefsson via Bug reports for the GNU Internet utilities <[email protected]> Mon, 08 Jul 2024 19:15:43 +0200
Newsgroups gmane.comp.gnu.inetutils.bugs
Message-ID <[email protected]>
Erik Auerswald <[email protected]> writes:

> Hi Collin,
>
> On Mon, Jul 01, 2024 at 12:31:37PM -0700, Collin Funk wrote:
>> Erik Auerswald <[email protected]> writes:
>> 
>> > Have you looked if you could add a (regression) test for this?
>> >
>> > Hm, the ping tests are skipped for me because they need to be run as
>> > root.
>> 
>> Not specifically for this case. […]
>
> It seems as if the ping tests actually run in Simon's GitLab-based CI,
> and they did not catch the problems, I think.

Those run as root though.  On Debian-like systems, the net-tools and
procps packages results in better testing coverage.

/Simon
signature.asc (application/pgp-signature, 255 B)
-----BEGIN PGP SIGNATURE-----

iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCZowevxQcc2ltb25Aam9z
ZWZzc29uLm9yZwAKCRBRcisI/kdFor0ZAP9hvI71gYMd2EnOhY76iqVvWGTc/xqa
qYlxDjHUH0U1awEAgFUp1S0euQ3b3shrxaw6X79AAETz2drwGzSisT2QowY=
=kESQ
-----END PGP SIGNATURE-----